style(tools): convert absolute to relative imports across codebase#1907
style(tools): convert absolute to relative imports across codebase#1907marioevz merged 1 commit intoethereum:mainfrom
Conversation
richardgreg
force-pushed
the
feat/relative-imports
branch
2 times, most recently
from
6a3b560 to
6467c0f
Compare
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
@richardgreg thank you for the PR! I left two comments around catching the ImportError. I'd prefer to leave those as absolute imports, but let me know what you think. I'm open to changing my mind :)
@marioevz I think this looks good overall. Can you confirm that these files will always be run via pytest and not as a script (for example: python src/cli/eest/make/cli.py). Pytest will resolve the relative imports efficiently, but if it's run as a script, the relative imports will not be found. I did a quick audit and didn't see anywhere we'd directly run these files, but don't feel familiar enough with the codebase yet to be sure. Thanks!
richardgreg
force-pushed
the
feat/relative-imports
branch
2 times, most recently
from
45130ef to
8e65586
Compare
|
@marioevz I ran the |
Convert absolute imports to relative imports within the same package Changes affect: * CLI components (eest, eofwrap) * Test files across all packages * Pytest plugin components (consume, execute, filler) * Framework utility modules
richardgreg
force-pushed
the
feat/relative-imports
branch
from
8e65586 to
df0888e
Compare
3 participants
🗒️ Description
Convert absolute imports to relative imports within the same package
Changes affect:
🔗 Related Issues or PRs
N/A.
Related to #1844 #1848
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.